Add IdleRegister to deal with destruction while idle func is queued
#3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a little helper class to `guiutils.*` that unregisters in-flight idle functions queued by `IdleRegister::add()`. It's best to call `IdleRegister::destroy()` in the destructor of the class owning the `IdleRegister` instance. Otherwise make sure, it is the last member which will be deleted first. `Resize` now makes use of this new facility in `setDimensions()`, which also fixes #3673.
|
@Hombre57 @heckflosse @Beep6581 That's it for this PR. Please test. Replacing |
|
@Floessie Very nice work ! But do you have some recommendations on how to test this branch ? |
|
@Floessie I locally merged |
|
@Floessie Thanks for fixing the crash so quickly! I tested a build with your patch. No crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a little helper class to
guiutils.*that unregistersin-flight idle functions queued by
IdleRegister::add(). It's bestto call
IdleRegister::destroy()in the destructor of the classowning the
IdleRegisterinstance. Otherwise make sure, it is thelast member which will be deleted first.
Resizenow makes use of this new facility insetDimensions(), whichalso fixes #3673.